Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACME IDN description. Issue #10442 #837

Merged
merged 1 commit into from
Apr 23, 2020
Merged

ACME IDN description. Issue #10442 #837

merged 1 commit into from
Apr 23, 2020

Conversation

vktg
Copy link
Contributor

@vktg vktg commented Apr 10, 2020

Redmine Issue: https://redmine.pfsense.org/issues/10442
Ready for review

this fix uses descr field name instead of desc,
it's included in the $cdata_fields of xmlparser.inc

@vktg vktg changed the title ACME IDN description. Isseu #10442 ACME IDN description. Issue #10442 Apr 10, 2020
jim-p
jim-p requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@jim-p jim-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be fine for new additions but it would lose the description of any existing entries. It needs some code to convert from the old to the new field (during the installation, perhaps)

@vktg
Copy link
Contributor Author

vktg commented Apr 15, 2020

done
now it converts to in acme_custom_php_install_command()

@vktg vktg mentioned this pull request Apr 23, 2020
Merged
@vktg
Copy link
Contributor Author

vktg commented Apr 23, 2020

can be merged with #847

@netgate-git-updates netgate-git-updates merged commit 2e23fb7 into pfsense:devel Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p jim-p jim-p approved these changes

Assignees
No one assigned
Labels
Changes requested
Projects
None yet
Milestone
No milestone
4 participants
@vktg @jim-p @rbgarga @netgate-git-updates