Build HAProxy Package with buildin Prometheus exporter. Implement #10500 #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p
requested changes
May 15, 2020
it is already there FreeBSD-ports/net/haproxy/Makefile Line 39 in a198c1a PR updated |
jim-p
requested changes
May 18, 2020
net/haproxy/Makefile
Outdated
| @@ -28,7 +28,7 @@ DPCRE_DESC= Link dynamically | |||
| SPCRE_DESC= Link statically | |||
| DEVICEATLAS_DESC= DeviceAtlas Device Detection support | |||
| PROMEX_DESC= Enable Prometheus exporter | |||
| OPTIONS_DEFAULT= SPCRE OPENSSL | |||
| OPTIONS_DEFAULT= SPCRE OPENSSL PROMEX | |||
There was a problem hiding this comment.
Don't change the default options. Add/change the relevant lines in the pfSense repository in https://github.com/pfsense/pfsense/blob/master/tools/conf/pfPorts/make.conf
There was a problem hiding this comment.
done: pfsense/pfsense#4320
Merged
2 tasks
jim-p
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine Issue: https://redmine.pfsense.org/issues/10500
Ready for review
However, PROMEX is not built by default with HAProxy. It is provided as an extra
component for everyone want to use it. So you need to explicitly build HAProxy
with the PROMEX service, using the Makefile variable "EXTRA_OBJS". For instance:
make TARGET=linux-glibc EXTRA_OBJS="contrib/prometheus-exporter/service-prometheus.o"if HAProxy provides the PROMEX service, the following build option will be
reported by the command "haproxy -vv":
https://github.com/haproxy/haproxy/blob/master/contrib/prometheus-exporter/README
needs testing on 2.5 first