This repository has been archived by the owner on Jan 22, 2018. It is now read-only.
lightsquid package reworked #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doktornotor
commented
Oct 18, 2015
doktornotor
commented
- provide instructions to users and add corresponding input validation; completely stop touching Squid packages configuration directly
- fix cronjob handling
- fix 'Skip URL(s)' handling and add some basic validation to it as well
- fix lightsquid.cfg handling
- fix English and clean up the GUI
- fix file permissions
- add privileges configuration
- code style fixes
- HTML fixes
- ...
added 17 commits
October 18, 2015 09:33
- fix English and clean up the GUI - provide instructions to users and add corresponding input validation; completely stop touching Squid packages configuration directly - fix 'Skip URL(s)' handling and add some basic validation to it as well - fix copyright header, indentation, whitespace - fix file permissions - add privileges configuration
- Fix cronjob handling - Fix lightsquid.cfg handling - Provide instructions to users and add corresponding input validation; completely stop touching Squid packages configuration directly - Remove unused junk - Provide some logging for debugging purposes and add comments - Code style fixes
added 7 commits
October 18, 2015 18:02
|
As noted above, what the heck is that assignment doing inside the if() ?! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.