Skip to content
This repository has been archived by the owner on Jan 22, 2018. It is now read-only.

add support for quagga ospfd raw config support #609

Merged
merged 3 commits into from
May 8, 2014

Conversation

dhoffend
Copy link
Contributor

rewrote the not-completed raw config support for ospfd.conf and zebra.conf to support stuff like zebra static routes and more complex szenarios.

hint: you must once fill out the assistent configuration otherwise the later parts like generate rc-scripts or carp detection won't work. but the generated ospfd/zebra config will work.

I've added the raw ospfd.conf and zebra.conf as output of the status page to get more details.

@@ -74,20 +74,20 @@ function quagga_ospfd_install_conf() {
$quagga_config_base = PKG_QUAGGA_CONFIG_BASE;

$noaccept = "";

// generate ospfd.conf based on the assistant
if($config['installedpackages']['quaggaospfd']['config'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better check using is_array()

@dhoffend
Copy link
Contributor Author

dhoffend commented Apr 7, 2014

@rbgarga I updated the the check. But this code came originally from the old package: see https://github.com/pfsense/pfsense-packages/blob/master/config/quagga_ospfd/quagga_ospfd.inc#L84

@rbgarga
Copy link
Member

rbgarga commented May 8, 2014

I tested it and it looks good. Please just bump the package version at pkg_config.10.xml and pkg_config.8.xml* and I'll merge it

@dhoffend
Copy link
Contributor Author

dhoffend commented May 8, 2014

Done. Thank you

@netgate-git-updates netgate-git-updates merged commit 76a6a0e into pfsense:master May 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants