Skip unresolved OpenVPN alias DNS entries. Fixes #12984

pfsense · Mar 25, 2022 · 4533e50 · 4533e50
1 parent 65adb19
commit 4533e50
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/etc/inc/openvpn.inc b/src/etc/inc/openvpn.inc
@@ -2284,8 +2284,13 @@ function openvpn_gen_routes($value, $ipproto = "ipv4", $push = false, $iroute =
 						$recordtypes = array(DNS_AAAA);
 						$mask = "/128";
 					}
-					foreach (resolve_host_addresses($net, $recordtypes, false) as $net) {
-						$networks[] = $net . $mask;
+					$domips = resolve_host_addresses($net, $recordtypes, false);
+					if (!empty($domips)) {
+						foreach ($domips as $net) {
+							$networks[] = $net . $mask;
+						}
+					} else {
+						log_error(gettext("Failed to resolve {$net}. Skipping OpenVPN route entry."));
 					}
 				}
 			}