-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to easyrule cli script #1444
Improvements to easyrule cli script #1444
Conversation
oliwel
commented
Jan 18, 2015
- add method to "unblock" a former block rule
- derive name of block list alias from script, allowing management of multiple individial lists by using symlinks
Block rules added with easyrule block.... can now be listed and removed using the easyrule tool. This is handy to be used with external IDS like tools, e.g fail2ban.
Allows to use different block lists by using symlinks to the easyrule CLI script
return gettext("Host unblocked successfully"); | ||
} | ||
} else { | ||
return gettext("Host ist not on block list: " . $host); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ist/is/
I guess you have revealed your European background :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should either add more caffeine or stop coding after midnight....
In order to get patches applied you must sign Individual or Corporate CLA as described at https://www.pfsense.org/about-pfsense/#legal |
CLA signed |
Conflicts: etc/inc/easyrule.inc
@rbgarga I signed the CLA 4 weeks ago and remerged the current master to solve the conflicst. Might you consider to merge this or are there any objections? |
@phil-davis @rbgarga |
@@ -91,11 +91,24 @@ function is_specialnet($net) { | |||
|
|||
|
|||
if (($argc > 1) && !empty($argv[1])) { | |||
|
|||
# Automagically derive an alternate alias name from the scripts name | |||
# This allows for using alternate alias lists with just a symlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the long delay. Please just fix this comment style using /* */, that is recommended way for multiline comments and I'll get it merged
done |