Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to easyrule cli script #1444

Merged
merged 5 commits into from
May 28, 2015

Conversation

oliwel
Copy link

@oliwel oliwel commented Jan 18, 2015

  • add method to "unblock" a former block rule
  • derive name of block list alias from script, allowing management of multiple individial lists by using symlinks

Block rules added with easyrule block.... can now be listed and removed using
the easyrule tool. This is handy to be used with external IDS like tools, e.g
fail2ban.
Allows to use different block lists by using symlinks to the
easyrule CLI script
return gettext("Host unblocked successfully");
}
} else {
return gettext("Host ist not on block list: " . $host);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ist/is/
I guess you have revealed your European background :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should either add more caffeine or stop coding after midnight....

@rbgarga
Copy link
Member

rbgarga commented Feb 2, 2015

In order to get patches applied you must sign Individual or Corporate CLA as described at https://www.pfsense.org/about-pfsense/#legal

@oliwel
Copy link
Author

oliwel commented Feb 2, 2015

CLA signed

Conflicts:
	etc/inc/easyrule.inc
@oliwel
Copy link
Author

oliwel commented Mar 3, 2015

@rbgarga I signed the CLA 4 weeks ago and remerged the current master to solve the conflicst. Might you consider to merge this or are there any objections?

@oliwel
Copy link
Author

oliwel commented May 21, 2015

@phil-davis @rbgarga
Guys, is there any reason why this isnt processed? Can I assist in anything? I would really appreciated to see this in the official release

@@ -91,11 +91,24 @@ function is_specialnet($net) {


if (($argc > 1) && !empty($argv[1])) {

# Automagically derive an alternate alias name from the scripts name
# This allows for using alternate alias lists with just a symlink
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the long delay. Please just fix this comment style using /* */, that is recommended way for multiline comments and I'll get it merged

@oliwel
Copy link
Author

oliwel commented May 27, 2015

done

@netgate-git-updates netgate-git-updates merged commit a6f973a into pfsense:master May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants