Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate CAs in certificate manager #3

Closed
wants to merge 4 commits into from

Conversation

EvgenyY
Copy link
Contributor

@EvgenyY EvgenyY commented Jun 22, 2011

I did not push it as I'd like somebody to review the code of my last commit.

@ermal
Copy link
Contributor

ermal commented Jun 22, 2011

I just made comments on this to your merge request.
Overall it looks fine but some more error handling is needed.

On Wed, Jun 22, 2011 at 7:12 AM, EvgenyY
reply@reply.github.com
wrote:

I did not push it as I'd like somebody to review the code of my last commit.

Reply to this email directly or view it on GitHub:
https://github.com/bsdperimeter/pfsense/pull/3

Ermal

@EvgenyY
Copy link
Contributor Author

EvgenyY commented Jun 22, 2011

eri>Why create this temporary variables...
I reused existing code. Now some removed.
eri>No error checking, please see below. I've done some error checking in Intermediate CA creation thread, if it is ok, I'll do the same in other place of cert manager.
eri>Can you create functions for kind of API get_ca_list() ....?
what for? anyway I have to load every value into ... Error checking implemented. Please take a look at https://github.com/EvgenyY/pfsense/commit/45a5628ca4978d91d36cd563e15fa4a1c8e9029e

@ermal
Copy link
Contributor

ermal commented Jun 23, 2011

Please commit directly both commits or a full diff with the error checking.

@EvgenyY
Copy link
Contributor Author

EvgenyY commented Jun 23, 2011

@EvgenyY EvgenyY closed this Jun 23, 2011
netgate-git-updates pushed a commit that referenced this pull request Aug 26, 2015
netgate-git-updates pushed a commit that referenced this pull request Jan 26, 2017
vktg pushed a commit to vktg/pfsense that referenced this pull request Feb 15, 2020
…ense#3)

Add RADIUS IP priority to vpn_ipsec_mobile.php. Implements #8160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants