Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP6 Before RA. Additions and ammendments (another version) #3102

Merged
merged 2 commits into from Sep 2, 2016
Merged

DHCP6 Before RA. Additions and ammendments (another version) #3102

merged 2 commits into from Sep 2, 2016

Conversation

NewEraCracker
Copy link
Contributor

An alternative implementation of PR #3092

Replaced posix_kill() in kill_dhcp6client_process() with mwexec("kill -9 $pid"), this is because the posix_kill call was not reliably killing the dhcp6c process, kill -9 works every time.

Changes to the rtsold script creation. The script lines starting dhcp6c should not have be written to the script when dhcpwithoutra is true.

Style corrections, I spend more time doing these than changing code!

I have done some changes to style, fixed the conflict (the received typo, see #3094), and changed kill_dhcp6client_process to look more like it's v4 counterpart.

Credits are kept as @marjohn56 had the original idea.

Thanks!
Please backport to RELENG_2_3 if accepted.

@NewEraCracker NewEraCracker changed the title DHCP6 Before RA. Additions and ammendments DHCP6 Before RA. Additions and ammendments (another version) Aug 13, 2016
@NewEraCracker
Copy link
Contributor Author

NewEraCracker commented Aug 13, 2016

Tested this on a small IPv6 network based on virtual machines on VMware 12.1.1 and works as expected.

@NewEraCracker
Copy link
Contributor Author

Closing this PR

After a lot discussion, this surely needs much more research and testing before being considered a good solution for the problem at hand.

Research will continue. There might be an easier solution lying around that hasn't been spotted yet.

@NewEraCracker
Copy link
Contributor Author

Reopening this. I am open to suggestions and improvements before considering this good to go.

Good news are, while researching on this I've found #3103 and this will surely fix the concurrency issues with quick link down/up transitions and the behavior of the dhcpd counterparts. That PR is safe and I am sure will help a lot of people affected by process double launch issues.

Now off to have some sleep! :)

@NewEraCracker NewEraCracker reopened this Aug 15, 2016
@marjohn56
Copy link
Contributor

I'll try and run this up over the next twenty four, Nice work.

@marjohn56
Copy link
Contributor

Applied this along with #3103 to the latest snapshot.... looking good.

marjohn56 and others added 2 commits September 2, 2016 19:21
Replaced posix_kill() in kill_dhcp6client_process() with mwexec("kill -9 $pid"), this is because the posix_kill call was not reliably killing the dhcp6c process, kill -9 works every time.

Changes to the rtsold script creation. The script lines starting dhcp6c should not have be written to the script when dhcpwithoutra is true.

Style corrections, I spend more time doing these than changing code!
When dhcp6c without RA is enabled, dhcp6c isn't killed and respawned, this causes the system not being able to pick up the routing changes. In this case, running the configuration script which fires rc.newwanipv6 solves the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants