New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added help descriptions for DNSMadeEasy fields in Dynamic DNS #3554
Conversation
Before this pull request can be accepted you must first sign a CLA as described at https://www.pfsense.org/about-pfsense/#cla. Please read for more details. |
@@ -293,6 +293,7 @@ function build_if_list() { | |||
)); | |||
|
|||
$group->setHelp('Enter the complete fully qualified domain name. Example: myhost.dyndns.org%1$s' . | |||
'DNS Made Easy: Dynamic DNS ID (NOT hostname)' . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add %1$s to the end of the line, it will be replaced by
@@ -351,6 +352,7 @@ function build_if_list() { | |||
'text', | |||
$pconfig['username'] | |||
))->setHelp('Username is required for all types except Namecheap, FreeDNS and Custom Entries.%1$s' . | |||
'DNS Made Easy: Dynamic DNS ID' . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add %1$s to the end of the line, it will be replaced by
@@ -361,6 +363,7 @@ function build_if_list() { | |||
'password', | |||
$pconfig['password'] | |||
))->setHelp('FreeDNS (freedns.afraid.org): Enter the "Authentication Token" provided by FreeDNS.%1$s' . | |||
'DNS Made Easy: Dynamic DNS Password' . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add %1$s to the end of the line, it will be replaced by
Hi. The documentation examples at https://dnsmadeeasy.com/technology/dynamic-dns/ claim So I think perhaps it should recommend that it be set to the account name/email, but also allow it to be left blank. I've tended to default to a EDIT: |
This was merged two years ago, so it's a bit late for comments. If you would like to propose a change to the current code, open a new feature request ticket at https://redmine.pfsense.org/ |
No description provided.