Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added help descriptions for DNSMadeEasy fields in Dynamic DNS #3554

Merged
merged 2 commits into from Apr 20, 2017
Merged

Added help descriptions for DNSMadeEasy fields in Dynamic DNS #3554

merged 2 commits into from Apr 20, 2017

Conversation

jeremyrnelson
Copy link
Contributor

No description provided.

@netgate-git-updates
Copy link

Before this pull request can be accepted you must first sign a CLA as described at https://www.pfsense.org/about-pfsense/#cla. Please read for more details.

@@ -293,6 +293,7 @@ function build_if_list() {
));

$group->setHelp('Enter the complete fully qualified domain name. Example: myhost.dyndns.org%1$s' .
'DNS Made Easy: Dynamic DNS ID (NOT hostname)' .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add %1$s to the end of the line, it will be replaced by

@@ -351,6 +352,7 @@ function build_if_list() {
'text',
$pconfig['username']
))->setHelp('Username is required for all types except Namecheap, FreeDNS and Custom Entries.%1$s' .
'DNS Made Easy: Dynamic DNS ID' .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add %1$s to the end of the line, it will be replaced by

@@ -361,6 +363,7 @@ function build_if_list() {
'password',
$pconfig['password']
))->setHelp('FreeDNS (freedns.afraid.org): Enter the "Authentication Token" provided by FreeDNS.%1$s' .
'DNS Made Easy: Dynamic DNS Password' .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add %1$s to the end of the line, it will be replaced by

@netgate-git-updates netgate-git-updates merged commit 51c7035 into pfsense:master Apr 20, 2017
@jeremyrnelson jeremyrnelson deleted the patch-1 branch May 18, 2017 03:35
@countingpine
Copy link

countingpine commented Feb 20, 2019

Hi.
I know this has been merged now, but it's worth saying that the username field is not needed at all. A URL of this form works: https://cp.dnsmadeeasy.com/servlet/updateip?id=1234567&password=...&ip=1.2.3.4

The documentation examples at https://dnsmadeeasy.com/technology/dynamic-dns/ claim username should be set to the DNSMadeEasy account name/email, so it's probably unwise to remove support for the field, but it would be nice to downgrade it to an optional one, and not to specify that it should be set to the ID.

So I think perhaps it should recommend that it be set to the account name/email, but also allow it to be left blank. I've tended to default to a . or similar.

EDIT:
For reference, I've added a Feature Request at https://redmine.pfsense.org/issues/9341
Sorry to spam this old pull request.

@jim-p
Copy link
Contributor

jim-p commented Feb 20, 2019

This was merged two years ago, so it's a bit late for comments. If you would like to propose a change to the current code, open a new feature request ticket at https://redmine.pfsense.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants