Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty port alias refactor #3677

Merged
merged 5 commits into from Mar 27, 2017
Merged

Handle empty port alias refactor #3677

merged 5 commits into from Mar 27, 2017

Conversation

phil-davis
Copy link
Contributor

This sits on top of #3670 and refactors to:

  1. Add "_" characters to various is_port_or* functions.
  2. Adds an is_portalias function, refactors is_port_or_alias to use it, refactors is_port_or_range_or_alias to call each of its 3 "parts" to get the answer.

@phil-davis phil-davis mentioned this pull request Mar 27, 2017
Merged
@rbgarga
Copy link
Member

rbgarga commented Mar 27, 2017 •
edited

Note: There are 2 packages that uses is_portoralias(). haproxy and haproxy-devel (already fixed)

@netgate-git-updates netgate-git-updates merged commit fe108b6 into pfsense:master Mar 27, 2017
netgate-git-updates pushed a commit that referenced this pull request Mar 27, 2017
@rbgarga
Merge pull request #3677 from phil-davis/handle-empty-port-alias-refa…
d52aed6 
…ctor
@phil-davis phil-davis deleted the handle-empty-port-alias-refactor branch March 28, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@phil-davis @rbgarga @netgate-git-updates