Fix a bug in status_gateways.php that causes incorrect Monitor IP to be shown #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug causes the Monitor IP to appear even when a gateway is unmonitored. The monitor IP from the last gateway in the list to have one will simply get repeated. This patch fixes that bug, and also cleans up a few other things- unused variables, gets var names to match whats in system_gateways.php, changes nest of if...elseif to cleaner switch() etc.
netgate-git-updates
pushed a commit
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in
status_gateways.phpthat causes Monitor IP to appear even when a gateway has monitoring disabled. The IP from the last gateway in the list will simply get repeated, as you can see in the screenshot below.This patch fixes that bug, and also cleans up a few other things: removes some unused variables, gets var names to match what's in
system_gateways.php, changes nest ofif..elseif..elseif..to cleanerswitch()etc.I also added the "(default)" text to show which gw's are currently default like they do on the gateway config page, for consistency.
before
after
