CP - add trim() to $_POST['auth_user'] & $_POST['auth_user2'] #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heper
commented
Jan 16, 2019
heper
commented
- Redmine Issue: https://redmine.pfsense.org/issues/9274
- Ready for review
jim-p
approved these changes
Jan 21, 2019
joshuasign
reviewed
Jan 23, 2019
| @@ -189,11 +189,11 @@ | |||
| $passwd = $cpcfg['radmac_secret']; | |||
| $context = 'radmac'; // Radius MAC authentication | |||
| } elseif (!empty($_POST['auth_user2'])) { | |||
There was a problem hiding this comment.
this shouldn't be better like that ?
} elseif (!empty(trim($_POST['auth_user2']))) {
because : empty(" ") is false
Also trim if() statement
netgate-git-updates
pushed a commit
that referenced
this pull request
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.