Issue 9595 #4072
Merged
Issue 9595 #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on a gateway group. Implementation now checks if OpenVPN client/server running on gateway group should resync when IP changes occur or if cables are unplugged/replugged.
|
Is it possible to get a review on this soon? |
jim-p
approved these changes
Jul 23, 2019
rbgarga
approved these changes
Aug 14, 2019
- Prevents potential race condition at startup resulting in failure to start OpenVPN instances. - In cases where interface file is not present the openvpn_resync function handles a restart correctly.
OpenVPN instances resync if interface IP change occurs. At boot, the interface is the empty string, so resync is mandatory to generate OpenVPN files in /var/etc/openvpn.
rbgarga
requested changes
Sep 3, 2019
GW Group changes are checked iff the interface is not the empty string or the interface in question is not the same as the OpenVPN interface.
rbgarga
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenVPN Gateway Group Fix
Implementation now checks if OpenVPN client/server running on gateway group should resync when IP changes occur or if cables are unplugged/replugged.
Replication Steps
VirtualBox
Physical Device
Fix Information
Fix brings the codebase more in line with the currrent implementation defined in rc.openvpn which accounts for situations where OpenVPN instances run on gateway groups.