system_crlmanager.php: fixed incorrect input validation #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p
requested changes
Dec 20, 2019
| @@ -148,6 +137,17 @@ | |||
| $input_errors[] = gettext("Invalid serial in list (Must be ASN.1 integer compatible decimal or hex string)."); | |||
| } | |||
| } | |||
| if (empty($pconfig['certref']) && empty($revoke_list)) { | |||
There was a problem hiding this comment.
This should be after the block below it, shouldn't it? Otherwise $revoke_list will always be empty if they selected a certificate and didn't enter a serial number.
There was a problem hiding this comment.
now it check if(!empty($pconfig['revokeserial'])) and check each value for ASN.1 compatibility
working ok now
jim-p
approved these changes
Dec 20, 2019
netgate-git-updates
pushed a commit
that referenced
this pull request
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalid input validation, multiple serials not allowed