inverse matching of tags. Issue #10186 #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p
requested changes
Jan 16, 2020
| @@ -521,6 +525,10 @@ function is_aoadv_used($rule_config) { | |||
| $input_errors[] = gettext("Invert match cannot be selected with 'any'."); | |||
| } | |||
|
|
|||
| if ((isset($_POST['nottagged']) && empty($_POST['tagged']))) { | |||
There was a problem hiding this comment.
There is an extra set of parenthesis on the outside this test
| $group->add(new Form_Checkbox( | ||
| 'nottagged', | ||
| 'nottagged', | ||
| 'Invert', |
There was a problem hiding this comment.
done,
but now GUI is not so pretty
There was a problem hiding this comment.
I see that now, it forces a word wrap. I guess it's OK to move it back to just 'Invert' and adjust the text below to match.
| $pconfig['tagged'] | ||
| ))->setWidth(4); | ||
|
|
||
| $group->setHelp('A packet can be matched on a mark placed before on another rule.'); |
There was a problem hiding this comment.
Change this to:
Match a mark placed on a packet by a different rule with the Tag option. Check Invert match to match packets which do not contain this tag.
vktg
force-pushed
the
nottagged
branch
2 times, most recently
from
1744dc8
to
eb4e805
Compare
jim-p
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to inverse tagged rules
i.e.
block out quick on RED_NET ! tagged RED_NET_OK