Replace double quote character in DHCP client ID. Issue #10295

[vktg]

• Redmine Issue: https://redmine.pfsense.org/issues/10295
• Ready for review

The following is allowed by the webgui in a static mapping: Client Identifier: 32" Sony Trinitron
That creates a configuration that cannot be loaded:

host s_lan_0 {
        hardware ethernet 01:02:03:04:05:06;
        option dhcp-client-identifier "32" Sony Trinitron";
    option host-name "32-Sony";
    option domain-name-servers 172.25.228.1;
}

This fix replaces the double quote character with '&quot';
There is no issue with other special characters (',./!@#$%^&*()~)

[jim-p]

Does escaping the double quote as \" work? That seems like a better choice if it does.

[vktg]

It works with \" too
Replaced