NTP status/widget long IPv6 address. Issue #10307

[vktg]

• Redmine Issue: https://redmine.pfsense.org/issues/10307
• Ready for review

if I have a) an IPv6 NTP server, and b) the NTP status widget on the dashboard, the widget doesn't display the stratum correctly:

NTP Status 
Server Time    10:08:58 CST
Sync Source    2620:19:4000:100::86 (stratum )

Also NTP status page shows truncated IPv6 address

from ntpq(1):

 -w, --wide
         Display the full 'remote' value.

         Display the full value of the 'remote' value.  
         If this requires more than 15 characters, display the full value, emit
         a newline, and continue the data display properly indented on the next line.

This PR fixes both issues

[jim-p]

Most of this is unnecessary with the right bit of pre-processing.

If you only change the ntpq call as follows, then it all works with existing code:

exec('/usr/local/sbin/ntpq -pnw ' . $inet_version . ' | /usr/bin/tail +3 | /usr/bin/sed \'N;s/\n\s*//;P;D\'', $ntpq_output);

Trying to pass that sed string through double quoted strings from PHP is a PITA so best to flip to single quotes like shown in my example.

[jim-p]

Applying the patch as-is didn't work, the lines with a long hostname (like pool placeholders) had an empty ref column and other values were shifted over. See my review comment for a much simpler alternative fix.

[vktg]

Testing /usr/local/sbin/ntpq -pnw ' . $inet_version . ' | /usr/bin/tail +3 | /usr/bin/sed \'N;s/\n\s*//;P;D\' I found that it returns only 'oversized', but not 'normal' peer string

[jim-p]

Hmm, I saw both. But I did find another system where it failed in a different way. Try this instead:

exec('/usr/local/sbin/ntpq -pnw ' . $inet_version . ' | /usr/bin/tail +3 | /usr/bin/sed -E \'N;s/\n[[:blank:]]+/ /;P;D\'', $ntpq_output);

[rschell]

This solution is still not quite right. I'm losing the last peer which happens to be the active one.

for example:

results in:

the -pnw full results are something like: