Feature #10323 #4224
Merged
Feature #10323 #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kiokoman
commented
Mar 9, 2020
kiokoman
commented
- Redmine Issue: https://redmine.pfsense.org/issues/10323
- Ready for review
added knob for max peers min 3 max 10
Add min-max ntp peers default 4
rbgarga
requested changes
Mar 9, 2020
change from space to tab
|
done |
spell correction
correction as suggested by David from https://redmine.pfsense.org/issues/10323
text correction to reflect what David suggested
jim-p
requested changes
Mar 10, 2020
orphan mode and maximum candidate ntp peers on the same tos line increased default maxclock to 5 if config empty
min 4 max 25 default to 5 variable at the start of the file
forgot to change from 25 to variable ..
This reverts commit f761f85.
rbgarga
approved these changes
Mar 11, 2020
jim-p
requested changes
Mar 11, 2020
variable $min_candidate_peers and break of long line
string before the if
jim-p
requested changes
Mar 12, 2020
Reword + sprintf
jim-p
approved these changes
Mar 12, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.