Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating rules tab fix. Issue #4629 #4290

Merged
merged 1 commit into from Apr 30, 2020
Merged

Floating rules tab fix. Issue #4629 #4290

merged 1 commit into from Apr 30, 2020

Conversation

vktg
Copy link
Contributor

@vktg vktg commented Apr 25, 2020

fixes for previous PR #4286:

  1. if you enable PPPoE Server for example, then create floating rules with only PPPoE Server, and then remove/disable PPPoE Server service, you get PHP Warning: implode(): Invalid arguments passed in /usr/local/www/firewall_rules.php on line 694 error. This PR fixes it;
  2. removes PPTP Server entry code;
  3. uses ipsec_enabled() for IPsec checking;

@netgate-git-updates netgate-git-updates merged commit 3aeb860 into pfsense:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p jim-p jim-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vktg @jim-p @netgate-git-updates