Captive Portal per-user bandwidth input validation fix. Issue #9311 #4322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From redmine:
I have two routers running on 2.4.4-RELEASE-p2 (amd64) and they have radically different configurations-- one with about 25 active users and the other around 1200 active users. I just took the following steps on both routers to confirm that it's still a problem here:
This fix clears
<bwdefaultdn>
and<bwdefaultup>
if<peruserbw>
is disabled,otherwise these values used in
pfsense/src/etc/inc/captiveportal.inc
Line 1302 in a88b841
and
pfsense/src/etc/inc/captiveportal.inc
Line 1308 in a88b841