Set net.inet.ip.dummynet sysctl. Fixes #10780 #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vktg
commented
Jul 21, 2020
vktg
commented
- Redmine Issue: https://redmine.pfsense.org/issues/10780
- Ready for review
jim-p
requested changes
Jul 21, 2020
src/etc/inc/shaper.inc
Outdated
| "net.inet.ip.dummynet.io_fast" => "1", | ||
| "net.inet.ip.dummynet.hash_size" => "256", | ||
| "net.inet.ip.dummynet.pipe_slot_limit" => $max_qlimit | ||
| )); | ||
| init_config_arr(array('sysctl', 'item')); | ||
| if (is_array($config['sysctl']) && is_array($config['sysctl']['item'])) { |
There was a problem hiding this comment.
After init_config_arr() these will always be arrays, so this test is unnecessary.
jim-p
approved these changes
Jul 21, 2020
| "net.inet.ip.dummynet.io_fast" => "1", | ||
| "net.inet.ip.dummynet.hash_size" => "256", | ||
| "net.inet.ip.dummynet.pipe_slot_limit" => $max_qlimit | ||
| )); | ||
| init_config_arr(array('sysctl', 'item')); | ||
| if (!empty($config['sysctl']['item'])) { |
There was a problem hiding this comment.
Not that it needs changed now, but for future reference, this test is also unnecessary. It's harmless to run foreach on an empty array, it is effectively a no-op since the body of the statement never executes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.