Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite CPU loop on failed restore #4559

Closed
wants to merge 2 commits into from
Closed

Fix infinite CPU loop on failed restore #4559

wants to merge 2 commits into from

Conversation

PhilZ-cwm6
Copy link
Contributor

@PhilZ-cwm6 PhilZ-cwm6 commented Mar 4, 2022 •
edited

When restoring a backup with wrong password or a user custom iterations count different than 10k or 500k, GUI timed out in an infinite CPU loop

@PhilZ-cwm6
Fix infinite CPU loop on failed restore
d93053e 
When restoring a backup with wrong password or a user custom iterations count different than 10k or 500k, GUI timed out in an infinite CPU loop
@PhilZ-cwm6
Fix potential bugs and security issues
4272ff6 
- fall back to lower or legacy no iterations only during decryption: else, if encryption of config files fails for any reason, it can fall back to a config fil encrypted in a legacy format even on new pfsense versions
- in the CPU loop issue fixed by previous patch, the /tmp was filled with `php-encrypt*.enc` and `php-encrypt*.dec` files and all disk space was used killing the firewall: ensure any temp files are cleaned before calling same function inside its self
@PhilZ-cwm6 PhilZ-cwm6 closed this Mar 7, 2022
@PhilZ-cwm6 PhilZ-cwm6 deleted the PhilZ-cwm6-patch-2 branch March 19, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p jim-p jim-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PhilZ-cwm6 @jim-p