Always clean tmp backups & prevent legacy backup #4560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If backup fails for any reason (exp I/O): prevent creating legacy backups or backups with lower iterations count - If for some reason the decryption takes too long to finish (CPU overloaded during decryption), and decryption needs to fall back to previous version or legacy, new temp files can be created and old ones will not be removed. This patch ensure that any created temp files are properly deleted
|
I took a slightly different approach, see my comments on Redmine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If backup fails for any reason (exp I/O): prevent creating legacy backups or backups with lower iterations count
If for some reason the decryption takes too long to finish (CPU overloaded during decryption), and decryption needs to fall back to previous version or legacy, new temp files can be created and old ones will not be removed. This patch ensure that any created temp files are properly deleted
Redmine Issue: https://redmine.pfsense.org/issues/12897
Ready for review