Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Status > DHCP Leases showing wrong interface name #4585

Merged
merged 1 commit into from May 17, 2022
Merged

fix for Status > DHCP Leases showing wrong interface name #4585

merged 1 commit into from May 17, 2022

Conversation

luckman212
Copy link
Contributor

simple fix: ensure interface is enabled during enumeration loop

@luckman212
Copy link
Contributor Author

@jim-p I can read your mind, you're probably going to ask me to combine those ifs into

if (!is_array($dhcpifconf['range']) || !isset($dhcpifconf['enable'])) {
    continue;
}

@luckman212 luckman212 force-pushed the fix-status-dhcpleases-wrong-ifname branch from d9a0cb7 to 9176511 Compare May 7, 2022 17:01
@luckman212
Copy link
Contributor Author

@jim-p I squashed in that change.

@luckman212 luckman212 force-pushed the fix-status-dhcpleases-wrong-ifname branch from 9176511 to 8f0fc7e Compare May 7, 2022 19:40
@luckman212 luckman212 force-pushed the fix-status-dhcpleases-wrong-ifname branch from 80a251d to 22adbe0 Compare May 8, 2022 03:44
@luckman212
Copy link
Contributor Author

Sorry about the noisy pushes and squashes here. I had some issues with my GPG key signing.

@netgate-git-updates netgate-git-updates merged commit af2fcf5 into pfsense:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p jim-p jim-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@luckman212 @jim-p @netgate-git-updates