New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dyndns: Add LuaDNS provider #4663
Open
aaron-sierra
wants to merge
8
commits into
pfsense:master
Choose a base branch
from
aaron-sierra:dyndns-luadns
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve code reuse while making it easier to maintain consistent log messages by providing a formatted and translated message prefix, _logPrefix, to the updatedns class. Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
Set $status_intro to the common log message prefix, _logPrefix, in _checkStatus(). Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
Prepare for commmon handling of DDNS provider hostname capabilities by setting $allow_wildcard from the $ddns_attr table. With $allow_wildcard set using a reasonable default for is_domain(), the explicit simplification of wildcard hostnames is no longer needed. Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
Prepare for commmon handling of DDNS provider hostname capabilities by defaulting $host_to_check to the concatenation of host and domainname fields for "split domain"-type providers. Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
With $allow_wildcard set from the $ddns_attr table and apex domain handling from the common case, the dedicated condition for the Cloudflare providers (cloudflare and cloudflare-v6) is no longer needed. Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
Update the following providers: * Gandi LiveDNS (gandi-livedns and gandi-livedns-v6) * Linode (linode and linode-v6) * Yandex (yandex and yandex-v6) Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
Use common handling for apex and wildcard hosts. Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
I'm currently locked out of my Redmine account, but I'll update the PR when I get in and create the ticket. |
Support the LuaDNS v1 API (https://www.luadns.com/api.html) for Dynamic DNS updates. This complements the ACME support for the provider. Default TTL to 3600 seconds (1 hour), as in the LuaDNS web interface. Signed-off-by: Aaron Sierra <aaron@bubbl-tek.com>
aaron-sierra
force-pushed
the
dyndns-luadns
branch
from
December 12, 2023 22:27
bf87d5c
to
033cc71
Compare
For the record, I realized my Redmine account mistake, created a Redmine ticket, and updated this pull request description with the link on December 12, 2023. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement ACME support for LuaDNS by adding Dynamic DNS support for the provider.
If the updates refactoring host checking for other providers (Cloudflare, Gandi LiveDNS, Linode, Porkbun, and Yandex) are, too much to consider, I can easily drop those three commits without issue.
Apex, wildcard, and simple hosts have been tested.
IPv4 and IPv6 support have been tested.