Fix stale bandwidth-by-IP table entries #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the number of valid rows in the table reduced by more than 1 between updates, stale entries were left displayed at the end - e.g. 8 rows (0-7), then next update has only 5 rows (0-4). Row 5 is hidden but rows 6 and 7 remain displayed.
jim-p
added a commit
that referenced
this pull request
Mar 7, 2013
Fix stale bandwidth-by-IP table entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the number of valid rows in the table reduced by more than 1 between updates, stale entries were left displayed at the end - e.g. 8 rows (0-7), then next update has only 5 rows (0-4). Row 5 is hidden but rows 6 and 7 remain displayed.
This "feature" looks like it has been around ever since this module was first added.
Should fix http://forum.pfsense.org/index.php/topic,59714.msg321414.html#msg321414
The functional change is making a single "if" test at line 156/157 and the removed "}" at 181. The rest of the diff listing is just changes due to code indenting.