Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-language support #35

Closed
bzy-080408 opened this issue Apr 15, 2020 · 11 comments
Closed

Multi-language support #35

bzy-080408 opened this issue Apr 15, 2020 · 11 comments
Assignees
Labels
bug Something isn't working v1.2 Issue known to exist in v1.2 v1.3 Issue known to exist in v1.3 v1.4 Issue known to exist in v1.4 v1.5 Issue known to exist in v1.5 v1.6 Issue known to exist in v1.6 v1.7 Issue known to exist in v1.7 v1.8 Issue known to exist in v1.8 v1.9 Issue known to exist in v1.9 v1.10 Issue known to exist in v1.10 v1.11 Issue known to exist in v1.11 v1.12 Issue known to exist in v1.12 v1.13 Issue known to exist in v1.13 v1.14 Issue known to exist in v1.14 v1.15 Issue known to exist in v1.15 v1.16 Issue known to exist in v1.16 v1.17

Comments

@bzy-080408
Copy link

When to walk multilingual support

@pbatard
Copy link
Member

pbatard commented Apr 15, 2020

Please rephrase your question, as it is not clear what you are asking.

Are you asking about having more than English in the UEFI settings menu? Or is it something else?

And you should also realize that any question that starts with "When will feature X be available?" in a firmware that is clearly flagged as EXPERIMENTAL will be answered with "We don't know".

@bzy-080408
Copy link
Author

I mean adding Chinese, German, Japanese, etc.

@pbatard
Copy link
Member

pbatard commented Apr 15, 2020

Answer: When someone sends a patch to the edk2-devel mailing list to add support for them.

I would however wait until the firmware is no longer flagged as EXPERIMENTAL, since the menus are not finalized yet (and neither is the firmware), so it makes very little sense to add support for additional languages now because things can change drastically and completely new menu entries might be needed.

Please, do understand that this is NOT a finalized firmware. It is NOT ready for anything besides testing, so please don't ask for features that only make sense for a finalized firmware.

I will therefore close this issue now.

@pbatard pbatard closed this as completed Apr 15, 2020
@bzy-080408
Copy link
Author

OK,but what's the difference between start english and english?

@bzy-080408
Copy link
Author

It doesn't seem to make any difference.

@pbatard
Copy link
Member

pbatard commented Apr 15, 2020

Sorry, but I don't understand your question at all. What is "start english"? Where do you see that?

@bzy-080408
Copy link
Author

First option

@pbatard
Copy link
Member

pbatard commented Apr 15, 2020

That comes from edk2. Again, we are not planning to do anything that relates to the language until the firmware is finalized. That also applies to answering questions like "Why is menu X this way and not that way?". This is not a productive use of our time. Thank you.

@pftf pftf locked as off-topic and limited conversation to collaborators Apr 15, 2020
@samerhaj
Copy link
Member

samerhaj commented Apr 15, 2020

I think this is in reference to these current language options , which seem a bit confusing:

  1. what is the difference between English/French and Standard English/Standard French?
  2. Should we remove French/Standard French advertised support since none of the strings in the HII drivers are actually translated . Seems like just a couple of PCDs to set in the DSC file:
## Default current ISO 639-2 language: English & French.
 # @Prompt Default Value of LangCodes Variable.
 gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultLangCodes|"engfraengfra"|VOID*|0x0000001c

 ## Default current ISO 639-2 language: English.
 # @Prompt Default Value of Lang Variable.
 gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultLang|"eng"|VOID*|0x0000001d

 ## Default platform supported RFC 4646 languages: (American) English & French.
 # @Prompt Default Value of PlatformLangCodes Variable.
 gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en;fr;en-US;fr-FR"|VOID*|0x0000001e

 ## Default current RFC 4646 language: (American) English.
 # @Prompt Default Value of PlatformLang Variable.
 gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLang|"en-US"|VOID*|0x0000001f

image

@pbatard
Copy link
Member

pbatard commented Apr 15, 2020

I think there are other priorities right now, but if you want to go for it, please go ahead.

@samerhaj samerhaj self-assigned this Jun 19, 2020
@samerhaj
Copy link
Member

Will remove French

@samerhaj samerhaj reopened this Jun 19, 2020
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Jul 18, 2020
Set the supported RPi4 platform language to English (US),
and remove French.

This fixes pftf/RPi4#35

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Jul 18, 2020
Set the supported RPi3 platform language to English (US),
and remove French.

This fixes pftf/RPi4#35

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
@samerhaj samerhaj added bug Something isn't working v1.10 Issue known to exist in v1.10 v1.11 Issue known to exist in v1.11 v1.12 Issue known to exist in v1.12 v1.13 Issue known to exist in v1.13 v1.14 Issue known to exist in v1.14 v1.15 Issue known to exist in v1.15 v1.16 Issue known to exist in v1.16 v1.17 v1.2 Issue known to exist in v1.2 v1.3 Issue known to exist in v1.3 v1.4 Issue known to exist in v1.4 v1.5 Issue known to exist in v1.5 labels Jul 19, 2020
@samerhaj samerhaj added v1.6 Issue known to exist in v1.6 v1.7 Issue known to exist in v1.7 v1.8 Issue known to exist in v1.8 v1.9 Issue known to exist in v1.9 labels Jul 19, 2020
ardbiesheuvel pushed a commit to tianocore/edk2-platforms that referenced this issue Aug 13, 2020
Set the supported RPi3 platform language to English (US),
and remove French.

This fixes pftf/RPi4#35

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Reviewed-by: Pete Batard <pete@akeo.ie>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working v1.2 Issue known to exist in v1.2 v1.3 Issue known to exist in v1.3 v1.4 Issue known to exist in v1.4 v1.5 Issue known to exist in v1.5 v1.6 Issue known to exist in v1.6 v1.7 Issue known to exist in v1.7 v1.8 Issue known to exist in v1.8 v1.9 Issue known to exist in v1.9 v1.10 Issue known to exist in v1.10 v1.11 Issue known to exist in v1.11 v1.12 Issue known to exist in v1.12 v1.13 Issue known to exist in v1.13 v1.14 Issue known to exist in v1.14 v1.15 Issue known to exist in v1.15 v1.16 Issue known to exist in v1.16 v1.17
Projects
None yet
Development

No branches or pull requests

3 participants