move download commands to shell script

[Biswa96]

No description provided.

[pbatard]

Why?

Please understand that this directory has a specific aim: produce binaries that can be used by people who don't want to build the firmware themselves, and that is it.

It is not meant to be used as a starting point for people who want to build their own firmware. If that is what you want, then I will respectfully ask that you refer to edk2-platforms and sort your own scripts for the specific build scenario you are after.

In other words, as long as this repo can produce firmware binaries, and there aren't major issues or improvements that should be enacted for the build process (this is not one of them) we're not going to of out of our way to make it more usable for other people's specific workflows.

If you want your own build workflow, please clone the repository and then modify the scripts as you see fit for your own usage.

[pbatard]

Ah scratch that, I looked at it too fast and I see that your goal is to remove the PowerShell invocation altogether, which is something I can get behind.

I would however like it better if the downloads remained in the before-build section, as they have little to do with the build and I had placed them there for that very reason.

[pbatard]

Actually, no, you are moving the commands into the build script so my first interpretation was indeed correct.

I wouldn't have an issue with this PR if you used wget in the before-build section of the .yml, but otherwise, I fail to see why you want this change integrated (my suspicion being that it is to help a custom workflow that relies on reusing build_firmware.sh, which is not at all what this project is designed for).

Depending on how you can justify how this would actually benefit this project, I therefore don't think I want to apply this PR. Sorry.

[Biswa96]

OK, as you wish. I will spin off my scripts in a new repository. BTW, with some digging, I can now boot Debian Buster ARM64 with this project. Thank you <3

[pbatard]

Btw if you want networking on Buster with 4.19 kernels, you might be interested in this patch (or for 5.5 you can just pick the ones you'll see from the recent lkml threads).

The only other thing you'll need is this applied to the Pi 4 Dsdt.asl.

I'm actually waiting for that last one to be integrated to publish a new firmware binary here, since the recent Genet changes don't make much sense to have without the ACPI ones...

[EDIT: These commits have now been applied and the published firmware from this project contains all the required changes to have Genet working in Linux, as long as you apply the kernel patches mentioned above]

Now, SD Linux support will be a bit more tricky, as we're most likely going to need extensive modifications of sdhci-acpi.c. But then again, a good USB 3.0 drive is going to be much faster than SD, so you're probably better off not installing Linux on SD anyway.

[Biswa96]

Do you and other members of this project hang out in any IRC chat? I have some questions about this project and edk2 + rpi relation?

[samerhaj]

We use the Discord channel
#RPI4-UEFI-DEV on https://discordapp.com/invite/fqRhc8y

Also check out this website https://rpi4-uefi.dev/