-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new feature: provide an exclude-list, like rsync #9
Comments
This is highly desirable, but not necessary for Secure Campaign. |
Currently my exclude patters are not checked against the src lists. This is addressing issue #9
This is now working in pftool with a -e option. I have written jenkins tests for it and merged it into master. Currently I am just using the fnmatch() function provided by the system. We can change this if we want different functionality. I am going to close this issue for now. Do we need to add exclude support to the scripts? |
We still need to add this to the pfscripts |
Thanks. Let me me know when, and we can re-tag. |
I edited the pfscripts and retested. |
A user of the OS Campagin is using rsync, instead of pfcp, to get a 10x reduction in the amount of data being copied. (They are probably actually losing performance, because pfcp would add ~64x threads running on 3 FTAs, but the point is that they could potentially have the 10x as well as the 64x.)
I imagine we could parse the exclude-list into a read-only vector of regex_t, somewhere in the global options. Perhaps we could compile these once in the master-task initializations, and share out the pre-compiled list as part of options, or else share the uncompiled versions and have every process compile them locally. Either way, we then have a set of per-task compiled exprs.
Some of them might eliminate entire directories, whereas others could match files in multiple directories. So, I think we'd have to run through the list of regexes before worker_readdir() calls opendir(), and then maybe we have to run through the list again, before accepting each result from readdir(), unless we can do something clever to identify those regexes that apply only to directories, and those that apply only to files.
The text was updated successfully, but these errors were encountered: