Skip to content

Commit

Permalink
fix unittests
Browse files Browse the repository at this point in the history
  • Loading branch information
Denchick committed Dec 6, 2023
1 parent 5fcc526 commit b925c78
Show file tree
Hide file tree
Showing 6 changed files with 119 additions and 90 deletions.
3 changes: 3 additions & 0 deletions router/frontend_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func TestFrontendSimple(t *testing.T) {
beRule := &config.BackendRule{}

srv.EXPECT().Name().AnyTimes().Return("serv1")
srv.EXPECT().DatashardIds().AnyTimes().Return([]string{"sh1"})

cl.EXPECT().Server().AnyTimes().Return(srv)

Expand Down Expand Up @@ -167,6 +168,7 @@ func TestFrontendXProto(t *testing.T) {
beRule := &config.BackendRule{}

srv.EXPECT().Name().AnyTimes().Return("serv1")
srv.EXPECT().DatashardIds().AnyTimes().Return([]string{"sh1"})

/* query Router */

Expand Down Expand Up @@ -302,6 +304,7 @@ func TestFrontendSimpleCopyIn(t *testing.T) {
beRule := &config.BackendRule{}

srv.EXPECT().Name().AnyTimes().Return("serv1")
srv.EXPECT().DatashardIds().AnyTimes().Return([]string{"sh1"})

cl.EXPECT().Server().AnyTimes().Return(srv)

Expand Down
187 changes: 100 additions & 87 deletions router/mock/server/mock_server.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions router/relay/relay.go
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ func (rst *RelayStateImpl) ProcQuery(query pgproto3.FrontendMessage, waitForResp
}

spqrlog.Zero.Debug().
Str("server", server.Datashards()[0].ID()).
Strs("shards", server.DatashardIds()).
Type("query-type", query).
Msg("client process query")

Expand Down Expand Up @@ -918,7 +918,7 @@ func (rst *RelayStateImpl) DeployPrepStmt(qname string) (shard.PreparedStatement
Str("query", query).
Uint64("hash", hash).
Str("client", rst.Client().ID()).
Str("shard", rst.Client().Server().Datashards()[0].ID()).
Strs("shards", rst.Client().Server().DatashardIds()).
Msg("deploy prepared statement")

// TODO: multi-shard statements
Expand Down
8 changes: 8 additions & 0 deletions router/server/multishard.go
Original file line number Diff line number Diff line change
Expand Up @@ -439,4 +439,12 @@ func (m *MultiShardServer) Datashards() []shard.Shard {
return m.activeShards
}

func (m *MultiShardServer) DatashardIds() []string {
ret := []string{}
for _, shard := range m.activeShards {
ret = append(ret, shard.ID())
}
return ret
}

var _ Server = &MultiShardServer{}
1 change: 1 addition & 0 deletions router/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ type Server interface {
AddDataShard(clid string, shardKey kr.ShardKey, tsa string) error
UnRouteShard(sh kr.ShardKey, rule *config.FrontendRule) error
Datashards() []shard.Shard
DatashardIds() []string

Cancel() error

Expand Down
6 changes: 5 additions & 1 deletion router/server/shard.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (srv *ShardServer) Receive() (pgproto3.BackendMessage, error) {
Uint("single-shard", spqrlog.GetPointer(srv)).
Type("message-type", msg).
Str("txstatus", srv.TxStatus().String()).
Str("shard", srv.Datashards()[0].ID()).
Strs("shards", srv.DatashardIds()).
Msg("single-shard receiving msg from server")
return msg, err
}
Expand Down Expand Up @@ -194,4 +194,8 @@ func (srv *ShardServer) Datashards() []shard.Shard {
return []shard.Shard{srv.shard}
}

func (srv *ShardServer) DatashardIds() []string {
return []string{srv.shard.ID()}
}

var _ Server = &ShardServer{}

0 comments on commit b925c78

Please sign in to comment.