Support cancel proto msgs #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denchick
approved these changes
Jun 8, 2023
router/pkg/rulerouter/rulerouter.go
Outdated
| delete(r.clmp, cl.GetCancelPid()) | ||
| } | ||
|
|
||
| func (r *RuleRouterImpl) CancelCleint(csm *pgproto3.CancelRequest) error { |
| } | ||
| return nil | ||
| } | ||
| return fmt.Errorf("no client with pid %d", csm.ProcessID) |
There was a problem hiding this comment.
Im not sure if we should return an error here. Is this error will be passing to the client?
Seems like if there is no process, then client was already released?
There was a problem hiding this comment.
this error will not be passed to the client
router/pkg/rulerouter/rulerouter.go
Outdated
|
|
||
| if cl, ok := r.clmp[csm.ProcessID]; ok { | ||
| if cl.GetCancelKey() != csm.SecretKey { | ||
| return fmt.Errorf("cancel sekret does not match") |
| @@ -31,4 +31,3 @@ SELECT pg_is_in_recovery() /* target-session-attrs: read-only */ , id FROM tsa_t | |||
| NOTICE: send query to shard(s) : sh2 | |||
| ERROR: failed to find replica | |||
| message type 0x5a arrived from server while idle | |||
| ERROR: failed to find replica | |||
There was a problem hiding this comment.
Why are you drop this changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.