Unite admin-console/psql-console pre-routing logic.

[reshke]

essentially fixes #255

[Denchick]

Still crashing

router log:

➜  spqr git:(admin_console_imprv) ./spqr-router -c examples/2shardproxy.yaml run
2023/08/04 13:25:40 Running config: {
  "log_level": "log",
  "time_quantiles": null,
  "daemonize": false,
  "maintain_params": false,
  "with_jaeger": false,
  "pgproto_debug": false,
  "pid_filename": "",
  "log_filename": "",
  "host": "::1",
  "router_port": "6432",
  "admin_console_port": "7432",
  "grpc_api_port": "7010",
  "world_shard_fallback": true,
  "show_notice_messages": false,
  "init_sql": "examples/init.sql",
  "memqdb_backup_path": "memqdb.json",
  "router_mode": "PROXY",
  "jaeger_url": "",
  "frontend_rules": [
    {
      "db": "db1",
      "usr": "user1",
      "auth_rule": {
        "auth_method": "ok",
        "password": "strong"
      },
      "pool_mode": "TRANSACTION",
      "pool_discard": false,
      "pool_rollback": false,
      "pool_prepared_statement": true,
      "pool_default": false
    },
    {
      "db": "",
      "usr": "",
      "auth_rule": {
        "auth_method": "ok",
        "password": ""
      },
      "pool_mode": "TRANSACTION",
      "pool_discard": false,
      "pool_rollback": false,
      "pool_prepared_statement": false,
      "pool_default": true
    }
  ],
  "query_routing": {
    "multicast_unroutable_insert_statement": false,
    "default_route_behaviour": ""
  },
  "frontend_tls": {
    "sslmode": "disable",
    "key_file": "/etc/odyssey/ssl/server.key",
    "cert_file": "/etc/odyssey/ssl/server.crt",
    "root_cert_file": ""
  },
  "backend_rules": [
    {
      "db": "db1",
      "usr": "user1",
      "auth_rules": null,
      "auth_rule": null,
      "pool_default": false,
      "connection_limit": 100
    },
    {
      "db": "",
      "usr": "",
      "auth_rules": null,
      "auth_rule": null,
      "pool_default": true,
      "connection_limit": 2
    }
  ],
  "shards": {
    "sh1": {
      "hosts": [
        "localhost:5550"
      ],
      "type": "DATA",
      "tls": {
        "sslmode": "disable",
        "key_file": "/etc/odyssey/ssl/server.key",
        "cert_file": "/etc/odyssey/ssl/server.crt",
        "root_cert_file": ""
      }
    },
    "sh2": {
      "hosts": [
        "localhost:5551",
        "localhost:5552"
      ],
      "type": "DATA",
      "tls": {
        "sslmode": "disable",
        "key_file": "/etc/odyssey/ssl/server.key",
        "cert_file": "/etc/odyssey/ssl/server.crt",
        "root_cert_file": ""
      }
    }
  },
  "reuse_port": false
}
{"level":"info","node":"sh1","time":"2023-08-04T13:25:40+05:00","message":"adding nodee"}
{"level":"info","node":"sh2","time":"2023-08-04T13:25:40+05:00","message":"adding nodee"}
{"level":"info","path":"examples/init.sql","time":"2023-08-04T13:25:40+05:00","message":"autoconf file found"}
{"level":"info","time":"2023-08-04T13:25:40+05:00","message":"executing init sql"}
{"level":"info","query":"ADD SHARDING RULE r1 COLUMNS w_id;","time":"2023-08-04T13:25:40+05:00"}
{"level":"info","query":"ADD SHARDING RULE r2 COLUMNS id;","time":"2023-08-04T13:25:40+05:00"}
{"level":"info","query":"ADD SHARDING RULE r3 COLUMNS bid;","time":"2023-08-04T13:25:40+05:00"}
{"level":"info","query":"ADD KEY RANGE krid3 FROM 21 TO 30 ROUTE TO sh2;","time":"2023-08-04T13:25:40+05:00"}
{"level":"info","query":"ADD KEY RANGE krid2 FROM 11 TO 20 ROUTE TO sh1;","time":"2023-08-04T13:25:40+05:00"}
{"level":"info","query":"ADD KEY RANGE krid1 FROM 1 TO 10 ROUTE TO sh1;","time":"2023-08-04T13:25:40+05:00"}
{"level":"info","count":6,"filename":"examples/init.sql","time":"2023-08-04T13:25:40+05:00","message":"successfully init queries from file"}
{"level":"info","address":"[::1]:7432","time":"2023-08-04T13:25:40+05:00","message":"SPQR Administative Console is ready on"}
{"level":"info","address":"[::1]:6432","time":"2023-08-04T13:25:40+05:00","message":"SPQR Router is ready by postgresql proto"}
{"level":"info","address":"[::1]:7010","time":"2023-08-04T13:25:40+05:00","message":"SPQR GRPC API is ready on"}
{"level":"info","address":"localhost:6432","time":"2023-08-04T13:25:40+05:00","message":"SPQR Router is ready by postgresql proto"}
{"level":"info","ssl":false,"time":"2023-08-04T13:25:49+05:00","message":"init client connection"}
{"level":"info","time":"2023-08-04T13:25:49+05:00","message":"console.ProcClient start"}
{"level":"info","ssl":false,"time":"2023-08-04T13:25:58+05:00","message":"init client connection"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x139bec7]

goroutine 52 [running]:
github.com/jackc/pgx/v5/pgproto3.(*Backend).Send(0x0, {0x1b5a980, 0x212e7c0})
        /Users/denchick/Code/spqr/vendor/github.com/jackc/pgx/v5/pgproto3/backend.go:60 +0x27
github.com/pg-sharding/spqr/router/client.(*PsqlClient).Send(0xc0004bc270, {0x1b5a980?, 0x212e7c0})
        /Users/denchick/Code/spqr/router/client/client.go:759 +0xba
github.com/pg-sharding/spqr/router/console.(*Local).Serve(0xc00012ccd0?, {0x1b5ecb0, 0xc000110010}, {0x1b6a868, 0xc0004bc270})
        /Users/denchick/Code/spqr/router/console/console.go:101 +0x293
github.com/pg-sharding/spqr/router.(*InstanceImpl).serv(0xc00040cbd0, {0x1b623b0?, 0xc000012028}, 0x1)
        /Users/denchick/Code/spqr/router/instance.go:144 +0x472
github.com/pg-sharding/spqr/router.(*InstanceImpl).RunAdm.func2()
        /Users/denchick/Code/spqr/router/instance.go:243 +0x2a
created by github.com/pg-sharding/spqr/router.(*InstanceImpl).RunAdm
        /Users/denchick/Code/spqr/router/instance.go:242 +0xdf

psql log:

➜  spqr git:(admin_console_imprv) psql "host=localhost port=7432"               

                SQPR router admin console
        Here you can configure your routing rules
------------------------------------------------
        You can find documentation here 
https://github.com/pg-sharding/spqr/tree/master/docs

psql (14.8 (Homebrew), server console)
Type "help" for help.

denchick=> lock key range krid1;
        lock key range        
------------------------------
 lock key range with id krid1
(1 row)

denchick=> lock key range krid1;
^CCancel request sent
server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
!?> 

[Denchick]

todo

[reshke]

todo

fixed

[Denchick]

Now the router really doesn't crash. unlock/lock really works. But when you try to lock for the second time, the client freezes, nothing happens in the router log either

{"{"level":"info","time":"2023-08-07T16:14:16+05:00","message":"console.Pro client start"}
{"level":"debug","client":824637407232,"message":{"Type":"Query","String":"lock key range krid1;"},"time":"2023-08-07T16:14:17+05:00","message":"client received message"}
{"level":"debug","query":"lock key range krid1;","type":"*spqrparser.Lock","time":"2023-08-07T16:14:17+05:00","message":"processQueryInternal: parsed query with type"}
{"{"level":"debug","key-range":"krid 1","time":"2023-08-07T16:14:17+05:00","message":"memqdb: lock key range"}

Is it better to explicitly throw an error or just allow the operation?

[Denchick]

Discussed that it's great as it is.