Drop sharding rule, add relation definitions to dataspace #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consider deprecating sharding rules instead of dropping them |
|
sharding rules dropped from SQL api, however they still present in grpc API and in backend code |
EinKrebs
approved these changes
Jan 18, 2024
Closed
EinKrebs
requested changes
Jan 19, 2024
router/qrouter/proxy_routing.go
Outdated
| @@ -192,7 +189,8 @@ func (qr *ProxyQrouter) RouteKeyWithRanges(ctx context.Context, expr lyx.Node, m | |||
| spqrlog.Zero.Debug().Str("key", string(meta.params[e.Number-1])).Str("hashed key", string(hashedKey)).Msg("applying hash function on key") | |||
|
|
|||
| return qr.DeparseKeyWithRangesInternal(ctx, string(hashedKey), meta) | |||
| case *lyx.AExprConst: | |||
| case *lyx.AExprIConst: | |||
| if | |||
There was a problem hiding this comment.
yea...
just pushed a bunch of work
|
I would like to propose to use only one bound in key range (lower one). To check if given key lays within given keyrange we will only have to check that given key is greater (>=) then KR bound and no other (greater) key range satisfies the same. |
|
@reshke PR is obsolete, consider closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr we replace current routing logic based on sharding rules with new one, based on dataspaces.
refer
#431