Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed sharding rules from core & QDB #517

Merged
merged 3 commits into from Feb 26, 2024
Merged

Removed sharding rules from core & QDB #517

merged 3 commits into from Feb 26, 2024

Conversation

EinKrebs
Copy link
Collaborator

No description provided.

@EinKrebs EinKrebs mentioned this pull request Feb 22, 2024
Merged
Denchick
Denchick requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@Denchick Denchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the codebase again, as I have found a number of things that need to be removed. You could try searching for "sharding" or "rules".

coordinator/provider/coordinator.go Show resolved Hide resolved
pkg/clientinteractor/interactor.go Show resolved Hide resolved
qdb/etcdqdb.go Show resolved Hide resolved
@EinKrebs EinKrebs merged commit b9e35fd into master Feb 26, 2024
20 checks passed
@EinKrebs EinKrebs deleted the drop-sharding-rules branch February 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Denchick Denchick Denchick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EinKrebs @Denchick