Rewrite of youtube embed code #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed the information in the latest youtube docs on embedding: https://developers.google.com/youtube/player_parameters?hl=en Wrote a set of regexps to parse the various formats of youtube URLs from the location bar, the share button, and the embed src under the share options, as well as some legacy URLs from the docs site. The regexps extract the video id and a string of all the other URL parameters. If the URL was for a single video the params are split out and processed to remove autoplay and to convert the &t param into the embed's &start version. They're then splatted back into a string. If the URL was for a playlist from the location bar or share button then it's split into a playlist id and params with autoplay stripped out. If the URL was a more advanced URL from the playlist embed src then it's passed through because it's already the right format, just the autoplay is removed if present. (playist embed url, user uploads list, and videos matching a search query) After all of the above the URL is then built at the end based on those various sources and stuck into an <iframe> tag that has the appropriate other settings to do the new embeds. It defaults to HTML5 player, but will fallback and handle older platforms and mobile automatically.
| for ( $i = 0; $i < count($params); $i++ ) { | ||
|
|
||
| // convert regular video URLs that use &t=200 to start at 200sec into embed url style that uses &start=200 or &start=3m20s | ||
| $params[$i] = preg_replace("/\At=/i", "start=", $params[$i]); |
|
Thanks Chris! I'm going to deploy this on BCO for a bit to see how things shake out before we land it. Do you want to make an issue announcing this feature? |
|
Tried to deploy this and ran into some trouble that I don't have time to debug right now. I'll try to dig in during the evening this week to see what's up. The board is running PHP 5.3.8, just FYI. I really need to get an Ansible dev/deployment setup rolling for this thing. |
|
Thanks for trying it out, I'll make a copy of my dev VM when I have a chance and try to downgrade to PHP 5.3.8 to see if I can see what the issue is |
|
Say, did you have any luck? |
|
Unfortunately I haven't had time to try to setup an alternate dev environment with the older PHP yet. Thanks for pinging on this though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the information in the latest youtube docs on embedding:
https://developers.google.com/youtube/player_parameters?hl=en
Wrote a set of regexps to parse the various formats of youtube
URLs from the location bar, the share button, and the embed src
under the share options, as well as some legacy URLs from the docs
site.
The regexps extract the video id and a string of all the other
URL parameters.
If the URL was for a single video the params are split out and
processed to remove autoplay and to convert the &t param into the
embed's &start version. They're then splatted back into a string.
If the URL was for a playlist from the location bar or share button
then it's split into a playlist id and params with autoplay stripped
out.
If the URL was a more advanced URL from the playlist embed src then
it's passed through because it's already the right format, just the
autoplay is removed if present. (playist embed url, user uploads
list, and videos matching a search query)
After all of the above the URL is then built at the end based on
those various sources and stuck into an <iframe> tag that has the
appropriate other settings to do the new embeds. It defaults to
HTML5 player, but will fallback and handle older platforms and
mobile automatically.