Replace removed eregi calls with preg_match. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! |
|
@tkellen I'm glad you didn't merge this way back in April - I finally had some time to stand up the board locally today discovered when trying to go through the signup flow that I didn't have delimiters set on the regular expressions. That's been fixed so this should be good to go. Now that I've got the board running locally in Docker I should be able to start tackling some other items, including getting Sphinx updated in prep for an upgrade to PHP 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces calls to
eregiin favor ofpreg_match.eregiwas deprecated in PHP 5.3 and removed altogether in PHP 7.0.Merging this change should be the last updated required to make the board's PHP code fully compatible with PHP 8.2.