Accommodate X in Twitter embeds; Add Instagram and TikTok embeds; Fix quoting of embeds #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tkellen, this PR:
- Accommodates x.com in tweet embeds:
- Adds Instagram embeds
- Adds TikTok embeds
- Fixes quoting of embeds where the contents of the
<script>
tag were getting quoted. When quoted, Twitter, Instagram, and TikTok embeds will now just display the embedded URL.- Adds a new
js/embedding.js
file to avoid rendering JS from PHP and enable more complicated client-side scripting, like fetching TikTok oEmbed info (which we probably don't want to do server-side)