Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang tidy does not work #2614

Closed
26 tasks done
cvvergara opened this issue Feb 11, 2024 · 0 comments
Closed
26 tasks done

Clang tidy does not work #2614

cvvergara opened this issue Feb 11, 2024 · 0 comments
Assignees
Milestone

Comments

@cvvergara
Copy link
Member

cvvergara commented Feb 11, 2024

While trying to use clang-tidy
Tidying headers:

$ clang-tidy -header-filter=./include include/a*/*.h* --  -I/home/path/to/repo/include -isystem /usr/include/postgresql/15/server -I/usr/include/boost/ -I/usr/include
2 errors generated.
Error while processing /home/path/to/repo/include/alphaShape/pgr_alphaShape.h.
2 errors generated.
Error while processing /home/path/to/repo/include/astar/astar.hpp.
/home/path/to/repo/include/alphaShape/pgr_alphaShape.h:34:2: error: This is C++ header file [clang-diagnostic-error]
#error This is C++ header file
 ^
/home/path/to/repo/include/alphaShape/pgr_alphaShape.h:37:10: error: 'vector' file not found [clang-diagnostic-error]
#include <vector>
         ^~~~~~~~
Found compiler error(s). 

The reason for this failure is that pgr_alphaShape.h should be an hpp file

Renaming of h to hpp is needed on files like this one

TODO

List of directories containing .h files that probably need to be changed to .hpp files

  • alphaShape
  • bellman_ford
  • breadthFirstSearch
  • c_common
  • c_types
  • chinese
  • circuits
  • coloring
  • components
  • contraction
  • cpp_common
  • dijkstra
  • dominator
  • drivers
  • lineGraph
  • max_flow
  • ordering
  • planar
  • spanningTree
  • transitiveClosure
  • trsp
  • tsp
  • visitors
  • vrp
  • withPoints
  • yen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant