Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bootstrap and Jquery from authentication pages #6295

Closed
adityatoshniwal opened this issue May 18, 2023 · 2 comments
Closed

Remove Bootstrap and Jquery from authentication pages #6295

adityatoshniwal opened this issue May 18, 2023 · 2 comments
Assignees
Milestone

Comments

@adityatoshniwal
Copy link
Contributor

Convert the login pages bootstrap and jquery code to use React instead.

@adityatoshniwal adityatoshniwal self-assigned this May 18, 2023
adityatoshniwal added a commit to adityatoshniwal/pgadmin4 that referenced this issue Jun 19, 2023
adityatoshniwal added a commit to adityatoshniwal/pgadmin4 that referenced this issue Jun 29, 2023
adityatoshniwal added a commit to adityatoshniwal/pgadmin4 that referenced this issue Jun 29, 2023
akshay-joshi pushed a commit to akshay-joshi/pgadmin4 that referenced this issue Jul 7, 2023
@yogeshmahajan-1903
Copy link
Contributor

Issues found while testing -

1.Text should 'forgot password' instead of 'forgotten password'
2.In forgot password page, if user enter invalid user, no error is shown. Just page refreshes.
3.On reset password received below error on UI in case user clicks 2nd time on reset link & try tp reset password. .

  • success 0 errormsg "name 'MessageType' is not defined"info ""result null data null.
    4.Unable to change password after login , 'name 'internal_server is not defined' error.
    5.Clicking setup MFA first time gives error - Something went wrong. (I guess incorrect redirection).After refesh able to setup MFA with email
    6.Unable to change password, 'name 'bad_request is not defined' error if user enters same password as old.
    7.Now the tab title is login for pgAdmin page. expected title should pgAdmin.
    8.User is able to click on login though username, password are empty.

adityatoshniwal added a commit to adityatoshniwal/pgadmin4 that referenced this issue Jul 11, 2023
@akshay-joshi akshay-joshi added this to the 7.5 milestone Jul 11, 2023
@yogeshmahajan-1903
Copy link
Contributor

This is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants