Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Folder issue for adding a sub-folder inside a folder. #6544

Closed
sanlinnaing opened this issue Jul 9, 2023 · 1 comment
Closed

Add Folder issue for adding a sub-folder inside a folder. #6544

sanlinnaing opened this issue Jul 9, 2023 · 1 comment
Assignees
@anilsahoo20
Labels
Bug EDB Sprint 146
Milestone
7.5

Comments

@sanlinnaing
Copy link
Contributor

Describe the bug

I found this issue in Server Mode which is installed on Docker environment.
In Storage Manager, when creating a sub-folder inside a folder, it created a folder with parent folder + sub-folder name.
For Example, if we create file in SubFolder2 in /Folder1, it created the folder /Folder1SubFolder2

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Tool -> Storage Manager...'
  2. Click on 'New Folder' button and add Folder1.
  3. Double click on Folder1 and click on "New Folder" button and add SubFolder2.
  4. Double click on SubFolder2 or "Go Back" button, see the error that /Folder1SubFolder2 created.

Expected behavior

It should be created the SubFolder2 in Folder1 and full path should be /Folder1/SubFolder2.

Error message

There is no Error message.

Screenshots

Here is the screenshot of error result.
Screenshot 2023-07-09 220339

Desktop (please complete the following information):

  • OS: Window 11
  • Version: 7.2
  • Mode: Server
  • Browser (if running in server mode): chrome
  • Package type: Container
@sanlinnaing sanlinnaing added the Bug label Jul 9, 2023
sanlinnaing added a commit to sanlinnaing/pgadmin4 that referenced this issue Jul 9, 2023
@sanlinnaing
fixed pgadmin-org#6544. Add Folder issue for adding a sub-folder insi…
441b4b4 
…de a folder.

Issue root cause is "/" omitted while `file_path` is making from `path` and `name`.
Fixed the issue of sub-folder adding issue by adding a process to check "/" is end of the `path` or start of the `name`.
adityatoshniwal pushed a commit that referenced this issue Jul 10, 2023
@sanlinnaing
Fix an issue where adding a sub-folder inside a folder is not working…
16a0950 
… as expected. #6544
@adityatoshniwal adityatoshniwal added this to the 7.5 milestone Jul 10, 2023
@anilsahoo20
Copy link
Contributor

Tested and verified on snapshot build: https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2023-07-13/
Environment: Latest docker image and pip wheel package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anilsahoo20 anilsahoo20

Labels
Bug EDB Sprint 146
Projects
None yet
Milestone
7.5
Development

No branches or pull requests
4 participants
@akshay-joshi @sanlinnaing @adityatoshniwal @anilsahoo20