Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgAdmin CLI pending bugs #7116

Closed
adityatoshniwal opened this issue Jan 10, 2024 · 5 comments · Fixed by #7279
Closed

pgAdmin CLI pending bugs #7116

adityatoshniwal opened this issue Jan 10, 2024 · 5 comments · Fixed by #7279
Assignees
Milestone

Comments

@adityatoshniwal
Copy link
Contributor

Couple of issues:

  1. If I run the command python setup.py set-prefs aditya.toshniwal14@gmail.com "browser:processes:process_retain_days=true" then it is success. Here, process retain days is a number.

  2. Login with an internal user for some email and run the below cmd. Then go to UI and open the preferences dialog. App crashes. I think we should logout the user if it is inactive.
    python setup.py update-user [aditya.toshniwal14@gmail.com](mailto:aditya.toshniwal14@gmail.com) --nonadmin --inactive --json --no-console

@yogeshmahajan-1903
Copy link
Contributor

yogeshmahajan-1903 commented Feb 13, 2024

Some more issues -
1.Tool tip for query tool shows query tool:logical_operator_new_line. Expected is - sqleditor:editor:logical_operator_new_line in preferences dialogue.
2.Tools tips are missing for drop downs in preferences dialogue.
3.If user provides boolean value 'false', preference setting is NOT updated.(Fixed with #6058)
4.CLI tool does not work in Desktop as default SQLITE_PATH taken is /var/lib/pgadmin/pgadmin4.db. Also no option to provide sqlite path value.

@pravesh-sharma
Copy link
Contributor

pravesh-sharma commented Feb 28, 2024

  1. I tried adding a user using CLI on Rocky 9, but it gives the below error. However, it works with the pip wheel package (macOS).
Screenshot 2024-02-28 at 2 37 19 PM
  1. When trying pgadmin4-cli on the pip wheel package it is not working.
Screenshot 2024-02-28 at 3 01 44 PM

Issue number 1 can be ignored as we need to run the script as root user.

@adityatoshniwal
Copy link
Contributor Author

Some more issues - 1.Tool tip for query tool shows query tool:logical_operator_new_line. Expected is - sqleditor:editor:logical_operator_new_line in preferences dialogue. 2.Tools tips are missing for drop downs in preferences dialogue. 3.If user provides boolean value 'false', preference setting is NOT updated.(Fixed with #6058) 4.CLI tool does not work in Desktop as default SQLITE_PATH taken is /var/lib/pgadmin/pgadmin4.db. Also no option to provide sqlite path value.

I suggest we should have tooltips on labels and not input controls. Having a tooltip on input is not a good UX.

pravesh-sharma added a commit to pravesh-sharma/pgadmin4 that referenced this issue Mar 13, 2024
pravesh-sharma added a commit to pravesh-sharma/pgadmin4 that referenced this issue Mar 14, 2024
pravesh-sharma added a commit to pravesh-sharma/pgadmin4 that referenced this issue Mar 14, 2024
@pravesh-sharma
Copy link
Contributor

Reopening for testing

@khushboovashi
Copy link
Contributor

Closing the issue.

I have created new issue for #7346 for the pending Preference validation issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants