Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Case Of Selected Text (Ctrl + Shift + L) in SQL Tool loses selection #7277

Closed
brsa opened this issue Mar 12, 2024 · 4 comments
Closed
Assignees
Milestone

Comments

@brsa
Copy link

brsa commented Mar 12, 2024

Another follow-up to #7268
Except that this issue has been there for some time now. Can't say when it started. It's present in v8.4.

Switching case of selected text in the SQL Tool is much needed functionality. Problem is that, currently, the selection is lost after (Ctrl + Shift + L). This is particularly tedious as the command regularly has to be applied twice. 1st time folds mixed-case to upper-case, 2nd time to lower-case. Keeping the selection would help a lot.

Since keeping the selection is the expected behavior in any case, I submit this as "bug", rather than as "feature request".

Regards
Erwin

@brsa brsa added the Bug label Mar 12, 2024
@adityatoshniwal
Copy link
Contributor

This issue is present since long and not related v8.4. This needs to be fixed.

adityatoshniwal added a commit that referenced this issue Mar 14, 2024
…election. #7277

Also make changes to give pgAdmin shortcuts higher priority over CodeMirror default shortcuts.
@adityatoshniwal adityatoshniwal removed their assignment Mar 14, 2024
@akshay-joshi akshay-joshi added this to the 8.5 milestone Mar 18, 2024
@pravesh-sharma
Copy link
Contributor

Found below issue on Linux OS:

If I change the default shortcut for the toggle case and then switch back to the default shortcut again, it does not work anymore.

@pravesh-sharma pravesh-sharma removed their assignment Mar 22, 2024
@adityatoshniwal
Copy link
Contributor

Found below issue on Linux OS:

If I change the default shortcut for the toggle case and then switch back to the default shortcut again, it does not work anymore.

I tested this on Mac, and I couldn't reproduce this.

@pravesh-sharma pravesh-sharma self-assigned this Mar 23, 2024
@pravesh-sharma
Copy link
Contributor

Issue resolved. Verified on latest snapshot build.

Env:
OS - macOS Sonoma and Rocky 9
Mode - Desktop and server
Browser - Google Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants