Expose UNIX socket for Docker #7224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `PGADMIN_SOCK` to `PGADMIN_ENABLE_SOCK` following the naming convention.
…creating the folder with root:root rights instead of pgadmin:root
…creating the folder with root:root rights instead of pgadmin:root
… because sometimes created the folders with root:root instead of pgadmin:root
|
I moved |
khushboovashi
requested changes
Feb 22, 2024
|
@DJviolin, can you please update your branch? |
|
I pulled the latest branch. Can you please verify the behavior of the mkdir command with multiple dirs? In my end, works without problem, creating multiple directories. If this is a problem, I gladly make it a separate command for the second dir. What do you suggest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this
entrypoint.shmodification, we expose an UNIX socket for Docker placed at/run/pgadmin/pgadmin.sock. IfPGADMIN_ENABLE_SOCKenvironment variable is not empty, it will create/run/pgadminfolder withpgadmin:rootrights and gunicorn creating it's socket there.I decided to not give the location from the environment variable, because user can create it anywhere in the file system, raising possible problems. Also placed in a folder, not directly in
/run, because in a Docker Compose stack helping to create a separate named volume only for this socket.Needs testing from others.
This pull request is originally mentoined in my issue here: #7221