Skip to content

Commit

Permalink
Correct snapshot upload error message (#546)
Browse files Browse the repository at this point in the history
The message currently says "Error uploading to S3", but with direct
snapshot upload or Enterprise server with different object storage
configured, snapshots may be going somewhere else.

Remove "S3" from the message.
  • Loading branch information
msakrejda committed May 13, 2024
1 parent 238561f commit 7165b6a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion output/compact.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func uploadAndSubmitCompactSnapshot(ctx context.Context, s pganalyze_collector.C

s3Location, err := uploadSnapshot(ctx, server.Config.HTTPClientWithRetry, grant, logger, compressedData, snapshotUUID.String())
if err != nil {
logger.PrintError("Error uploading to S3: %s", err)
logger.PrintError("Error uploading snapshot: %s", err)
return err
}

Expand Down
2 changes: 1 addition & 1 deletion output/full.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func submitFull(ctx context.Context, s snapshot.FullSnapshot, server *state.Serv

s3Location, err := uploadSnapshot(ctx, server.Config.HTTPClientWithRetry, server.Grant, logger, compressedData, snapshotUUID.String())
if err != nil {
logger.PrintError("Error uploading to S3: %s", err)
logger.PrintError("Error uploading snapshot: %s", err)
return err
}

Expand Down

0 comments on commit 7165b6a

Please sign in to comment.