Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Allow 'db_log_location' to take wildcard expressions #83

Closed
khanhibus opened this issue Sep 7, 2020 · 2 comments · Fixed by #146
Closed

Feature Request: Allow 'db_log_location' to take wildcard expressions #83

khanhibus opened this issue Sep 7, 2020 · 2 comments · Fixed by #146

Comments

@khanhibus
Copy link

I have a use case in which our postgres servers are logging both csv and stderr logs to the same location. The csv logs are forwarded to our local ELK stack for analysis. It would be tremendously helpful if the 'db_log_location' parameter could take a wildcard path such as:

  • /path/to/log/*.log

The reason for this request is that pganalyze-collector is ingesting both the csv and stderr logs. When looking at the Log Insights view, I am seeing both stderr and csv logs and suspect that is causing the Query Performance EXPLAIN Plans to not work. I have been running the on-premise version of pganalyze for a year and have yet to see any EXPLAIN Plans.

Thank you!
@lfittl
Copy link
Member

lfittl commented Nov 1, 2020

Hi @khanhibus - Thanks for the feedback, we're reviewing whether we can add this functionality.

If you'd like to get more direct help on the issue with your setup, please email support@pganalyze.com so we can review this in detail.

msakrejda added a commit that referenced this issue Feb 10, 2021
@msakrejda
Ignore CSV log files
1e7d058 
Some Postgres installations are configured to log both standard-format
log files and CSV log files to the same directory, but the collector
currently reads all files specified in a db_log_location, which works
poorly with this setup.

Since we already ignore some files (zipped log files), and we do not
support parsing CSV files, add CSV log files to this list.

Fixes #83
@msakrejda msakrejda mentioned this issue Feb 10, 2021
Merged
msakrejda added a commit that referenced this issue Feb 12, 2021
@msakrejda
Ignore CSV log files
0be1918 
Some Postgres installations are configured to log both standard-format
log files and CSV log files to the same directory, but the collector
currently reads all files specified in a db_log_location, which works
poorly with this setup.

Since we already ignore some files (zipped log files), and we do not
support parsing CSV files, add CSV log files to this list.

Fixes #83
@msakrejda
Copy link
Contributor

@khanhibus the change in #146 is not exactly what you were asking for, but I believe it should handle your use case. Please let us know if this does not work for you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore CSV log files pganalyze/collector
3 participants
@lfittl @msakrejda @khanhibus