Update from github.com/golang/protobuf to google.golang.org/protobuf #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The old module, github.com/golang/protobuf, has been deprecated a while, and the newer API has a slightly improved interface for the timestamp type as well, avoiding a potential error that needs to be handled (that we've traditionally ignored anyway in our own code). Note there is a remaining caller of the old module in Google's appengine module, which gets vendored in unnecessarily via x/oauth2 (golang/oauth2#615). In passing, update the protoc-gen-go tool as well to the version hosted in the new repository. Depends on pganalyze/collector-snapshot#30
lfittl
force-pushed
the
update-protobuf-library
branch
from
88118fb
to
43ca13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old module, github.com/golang/protobuf, has been deprecated a while, and the newer API has a slightly improved interface for the timestamp type as well, avoiding a potential error that needs to be handled (that we've traditionally ignored anyway in our own code).
Note there is a remaining caller of the old module in Google's appengine module, which gets vendored in unnecessarily via x/oauth2 (golang/oauth2#615).
In passing, update the protoc-gen-go tool as well to the version hosted in the new repository.
Depends on pganalyze/collector-snapshot#30 for the "go_package" option which is now required by protoc-gen-go.