pg_config.h: NetBSD support #172
Conversation
| # Ensure we don't fail on systems that have strchrnul support (FreeBSD) | ||
| echo "#ifdef __FreeBSD__" >> $(PGDIR)/src/include/pg_config.h | ||
| # Ensure we don't fail on systems that have strchrnul support (FreeBSD and NetBSD) | ||
| echo "#if defined(__FreeBSD__) || defined(__NetBSD__)" >> $(PGDIR)/src/include/pg_config.h |
There was a problem hiding this comment.
We do actually also need to apply it to the generated pg_config.h file in the repo (we cache the result of the Makefile and only run extract_source as needed) -- you can just make the edit directly in the file, or run the extract_source locally to generate it (but that might be a bit more involved):
https://github.com/pganalyze/libpg_query/blob/15-latest/src/postgres/include/pg_config.h#L1035
There was a problem hiding this comment.
Done. I did not manage to get make extract_source to work (neither on NetBSD nor on Debian) so this is a manual edit. PTAL :)
NetBSD has strchrnul too but with a slightly different prototype. Without this change, there is a compiler error for a conflicting declaration.
|
Can someone merge this, because I cannot :) |
Looks like there was a seemingly random build failure - will merge after thats resolved (hopefully on a re-run, that I started just now). |
This is the same as pganalyze/pg_query_go#72 except one level higher.
NetBSD has
strchrnultoo but with a slightly different prototype. Without this change, there is a compiler error for a conflicting declaration.