Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create table unique index parameters problem fixed #193

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Create table unique index parameters problem fixed #193

merged 4 commits into from
Jun 6, 2023
+14 −1

Conversation

emin100
Copy link
Contributor

@emin100 emin100 commented May 26, 2023 •
edited by seanlinsley
Loading 

     SQL: CREATE TABLE distributors (         
              did     int,
              name    varchar(40),
              UNIQUE (name) WITH (fillfactor=70)
            )
            WITH (fillfactor=70);

       expected: "CREATE TABLE distributors (did int, name varchar(40), UNIQUE (name) WITH (fillfactor=70)) WITH (fillfactor=70)"
            got: "CREATE TABLE distributors (did int, name varchar(40), UNIQUE (name)) WITH (fillfactor=70)"

pg_query PR: pganalyze/pg_query#287

@emin100
SQL: CREATE TABLE distributors (
c7453fd 
              did     int,
              name    varchar(40),
              UNIQUE (name) WITH (fillfactor=70)
            )
            WITH (fillfactor=70);
Failure/Error: it { is_expected.to eq oneline_query }

       expected: "CREATE TABLE distributors (did int, name varchar(40), UNIQUE (name) WITH (fillfactor=70)) WITH (fillfactor=70)"
            got: "CREATE TABLE distributors (did int, name varchar(40), UNIQUE (name)) WITH (fillfactor=70)"
@emin100 emin100 mentioned this pull request May 26, 2023
Closed
@emin100 emin100 marked this pull request as draft May 26, 2023 20:45
@emin100 emin100 marked this pull request as ready for review May 27, 2023 09:45
emin100 added a commit to emin100/extract_postgresql_documentation_sql_examples that referenced this pull request May 30, 2023
@emin100
pg_query-4.2.1 tested(new patches sended).
a56e164 
pganalyze/pg_query#287
pganalyze/libpg_query#193
sql with unescaped chars fixed.
results changed.
@emin100
SQL: SHOW ALL
5b26910 
expected: "SHOW ALL"
got: "SHOW SESSION ALL"
@emin100
Copy link
Contributor Author

emin100 commented Jun 2, 2023 •
edited
Loading

Fixed another problem.

SQL: SHOW ALL

expected: "SHOW ALL"
got: "SHOW SESSION ALL"

emin100 added a commit to emin100/pg_query that referenced this pull request Jun 2, 2023
@emin100
SQL: SHOW ALL
e6c5d9c 
expected: "SHOW ALL"
got: "SHOW SESSION ALL"

libpg_query PR: pganalyze/libpg_query#193
lfittl
lfittl approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@lfittl lfittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the contribution!

@lfittl lfittl merged commit 854f18f into pganalyze:15-latest Jun 6, 2023
8 checks passed
@lfittl lfittl mentioned this pull request Jun 6, 2023
Merged
@emin100 emin100 deleted the table_unique_with_parameter branch June 6, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfittl lfittl lfittl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emin100 @lfittl