Deparser: Add parens around TypeCast in IndexElem #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly omitting these parentheses, as well as missing a space outputting "CREATE INDEX ON t (col::typecastops_class)" instead of "CREATE INDEX ON t ((col::typecast) ops_class)". Fixes #213
This is mainly in use for RangeFunction, but the logic in the grammar here is more broad, allowing type casts to show up in places where a function call would be expected. Fix by always using the "cast(..)" syntax in such cases.
This covers the case where deparseFuncExprWindowless needs to handle a TypeCast and output like a function call, since the other cast syntax is not valid in FROM.
lfittl
force-pushed
the
deparser-fix-typecast-in-index-elem
branch
from
834000b
to
d1a2ffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly omitting these parentheses, as well as missing a space outputting "CREATE INDEX ON t (col::typecastops_class)" instead of "CREATE INDEX ON t ((col::typecast) ops_class)".
Fixes #213