Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ar variable in Makefile (back patch to v14) #240

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Fix: ar variable in Makefile (back patch to v14) #240

merged 1 commit into from
Feb 17, 2024

Conversation

gregnr
Copy link
Contributor

@gregnr gregnr commented Feb 16, 2024

Applies the same patch as #217 but to v14 (in order to use in v14 version of libpg-query-node).

Replaces the hardcoded AR variable:

AR = ar rs

with a reference to the upstream inherited AR variable:

AR ?= ar
AR := $(AR) rs

so that Emscripten's emar replacement is used.

@gregnr gregnr mentioned this pull request Feb 16, 2024
Merged
lfittl
lfittl approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@lfittl lfittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the contribution!

@lfittl lfittl merged commit 1577ef7 into pganalyze:14-latest Feb 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfittl lfittl lfittl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregnr @lfittl